Add Unresolved Transactions command in vtctld service (#16679)

Signed-off-by: Harshit Gangal <[email protected]>

go/cmd/vtctldclient/command/query.go

@@ -55,6 +55,13 @@ var (
 		RunE:                  commandExecuteMultiFetchAsDBA,
 		Aliases:               []string{"ExecuteMultiFetchAsDba"},
 	}
+	// GetUnresolvedTransactions makes an GetUnresolvedTransactions gRPC call to a vtctld.
+	GetUnresolvedTransactions = &cobra.Command{
+		Use:   "GetUnresolvedTransactions <keyspace>",
+		Short: "Retrieves unresolved transactions for the given keyspace.",
+		Args:  cobra.ExactArgs(1),
+		RunE:  commandGetUnresolvedTransactions,
+	}
 )
 
 var executeFetchAsAppOptions = struct {
@@ -198,6 +205,26 @@ func commandExecuteMultiFetchAsDBA(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
+func commandGetUnresolvedTransactions(cmd *cobra.Command, args []string) error {
+	cli.FinishedParsing(cmd)
+
+	keyspace := cmd.Flags().Arg(0)
+	resp, err := client.GetUnresolvedTransactions(commandCtx,
+		&vtctldatapb.GetUnresolvedTransactionsRequest{
+			Keyspace: keyspace,
+		})
+	if err != nil {
+		return err
+	}
+
+	data, err := cli.MarshalJSON(resp.Transactions)
+	if err != nil {
+		return err
+	}
+	fmt.Printf("%s\n", data)
+	return nil
+}
+
 func init() {
 	ExecuteFetchAsApp.Flags().Int64Var(&executeFetchAsAppOptions.MaxRows, "max-rows", 10_000, "The maximum number of rows to fetch from the remote tablet.")
 	ExecuteFetchAsApp.Flags().BoolVar(&executeFetchAsAppOptions.UsePool, "use-pool", false, "Use the tablet connection pool instead of creating a fresh connection.")
@@ -215,4 +242,6 @@ func init() {
 	ExecuteMultiFetchAsDBA.Flags().BoolVar(&executeMultiFetchAsDBAOptions.ReloadSchema, "reload-schema", false, "Instructs the tablet to reload its schema after executing the query.")
 	ExecuteMultiFetchAsDBA.Flags().BoolVarP(&executeMultiFetchAsDBAOptions.JSON, "json", "j", false, "Output the results in JSON instead of a human-readable table.")
 	Root.AddCommand(ExecuteMultiFetchAsDBA)
+
+	Root.AddCommand(GetUnresolvedTransactions)
 }

go/flags/endtoend/flags_test.go

@@ -22,13 +22,12 @@ package flags
 
 import (
 	"bytes"
+	_ "embed"
 	"os"
 	"os/exec"
 	"testing"
 	"text/template"
 
-	_ "embed"
-
 	"github.com/stretchr/testify/require"
 
 	"vitess.io/vitess/go/test/utils"

go/flags/endtoend/vtctldclient.txt

@@ -59,6 +59,7 @@ Available Commands:
   GetTablets                  Looks up tablets according to filter criteria.
   GetThrottlerStatus          Get the throttler status for the given tablet.
   GetTopologyPath             Gets the value associated with the particular path (key) in the topology server.
+  GetUnresolvedTransactions   Retrieves unresolved transactions for the given keyspace.
   GetVSchema                  Prints a JSON representation of a keyspace's topo record.
   GetWorkflows                Gets all vreplication workflows (Reshard, MoveTables, etc) in the given keyspace.
   LegacyVtctlCommand          Invoke a legacy vtctlclient command. Flag parsing is best effort.

go/test/endtoend/tabletmanager/commands_test.go

@@ -75,6 +75,11 @@ func TestTabletCommands(t *testing.T) {
 		require.Nil(t, err)
 		assertExecuteMultiFetch(t, result)
 	})
+
+	t.Run("GetUnresolvedTransactions", func(t *testing.T) {
+		_, err := clusterInstance.VtctldClientProcess.ExecuteCommandWithOutput("GetUnresolvedTransactions", keyspaceName)
+		require.NoError(t, err)
+	})
 	// check Ping / RefreshState / RefreshStateByShard
 	err = clusterInstance.VtctldClientProcess.ExecuteCommand("PingTablet", primaryTablet.Alias)
 	require.Nil(t, err, "error should be Nil")

go/test/endtoend/tabletmanager/main_test.go

@@ -105,6 +105,8 @@ func TestMain(m *testing.M) {
 			"--heartbeat_enable",
 			"--health_check_interval", tabletHealthcheckRefreshInterval.String(),
 			"--unhealthy_threshold", tabletUnhealthyThreshold.String(),
+			"--twopc_enable",
+			"--twopc_abandon_age", "200",
 		}
 
 		// Start keyspace