List all compatible version of vitess that were benchmarked #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the longest time we have only benchmarked and shown the last 3 supported releases of vitess. We want to keep doing the former, and change to 2 releases after v20.0 is EOL because of vitessio/enhancements#12. But we want to change the latter: as soon as a new release is out, we use to stop displaying the results of the oldest major release on the website. When we released v21.0, v18.0 was now 4 major versions behind main, meaning it wouldn't be shown on the website.
With this PR, we are now displaying all versions of vitess that were benchmarked with a compatible method than the one currently used by arewefastyet. Meaning, that if in the future, when e.g. v21.0 is the current latest version of Vitess, we change the methodology of arewefastyet enough that it "discards" all the previous results we had collected, then v19.0 will be the oldest compatible version of vitess that was benchmarked with the new methodology.