Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use host url to open browser #19414

Merged
merged 3 commits into from
Feb 20, 2025
Merged

feat: use host url to open browser #19414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab3f76
feat: use host url to open browser
Feb 13, 2025
57cc032
Merge branch 'vitejs:main' into feat/use-host-url-open-browser
Mrlilili Feb 13, 2025
886382c
refactor: reorder logic
sapphi-red Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,8 +658,15 @@ export async function _createServer(
},
openBrowser() {
const options = server.config.server
const url =
server.resolvedUrls?.local[0] ?? server.resolvedUrls?.network[0]
const host = options.host
let url: string | undefined
if (typeof host === 'string') {
url = [
...(server.resolvedUrls?.local ?? []),
...(server.resolvedUrls?.network ?? []),
].find((url) => url.includes(host))
}
url ??= server.resolvedUrls?.local[0] ?? server.resolvedUrls?.network[0]
if (url) {
const path =
typeof options.open === 'string'
Expand Down