Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use native runtime to import the config #19178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: use native runtime to import the config #19178

wants to merge 1 commit into from
+74 −30

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 10, 2025 •
edited
Loading

Description

Ref #18637 (--configLoader runner)

Adds support for --configLoader native, which uses the environment's runtime to load the config

NOTE:

  • It looks like the config playground should've been a unit test instead (I can clean this up later)

@bluwy bluwy changed the title Config loader native feat: use native runtime to import the config Jan 10, 2025
@bluwy bluwy force-pushed the config-loader-native branch from e487dab to ea8d558 Compare January 24, 2025 14:38
@bluwy bluwy marked this pull request as ready for review January 24, 2025 14:41
patak-dev
patak-dev approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds great to me 👏🏼

@patak-dev patak-dev added p2-nice-to-have Not breaking anything but nice to have (priority) performance Performance related enhancement labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) performance Performance related enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @patak-dev