fix(resolve): fix resolve cache key for external conditions

[hi-ogawa]

Description

I realized resolve cache still conflicts for ssr external resolution as it uses conditions: [] and overrideConditions instead internally. To fix this, I'm adding one more to cache key for now.

vite/packages/vite/src/node/ssr/fetchModule.ts

Lines 47 to 60 in f85aea2

	const resolved = tryNodeResolve(
	url,
	importer,
	{
	mainFields: ['main'],
	conditions: [],
	externalConditions,
	external: [],
	noExternal: [],
	overrideConditions: [
	...externalConditions,
	'production',
	'development',
	],

My use case / experiment is to externalize react in both ssr and rsc environments. I found the resolve bug still exists in hi-ogawa/vite-environment-examples#131 when testing pkg-pr-new from main.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sapphi-red]

I guess we should give users a way to remove the default conditions or change the default conditions to be an empty array, now that with the environment api, people would now might want to remove both browser and node conditions. overrideConditions was used to just to avoid breaking changes, and if we have a way to remove the default condition, we no longer need the overrideConditions.

[hi-ogawa]

Yeah, I agree there should be a better way to organize overrideConditions in general. But, should this fix wait for reworking conditions which seems to have a larger scope?

Maybe it would interesting to bring back proper ... conditions #17326 but in a proper breaking way to see how it can simplify things.

[patak-dev]

I agree with both here. In other cases, we have the opportunity to change options without a breaking change (with all the options we moved from server to dev), but here I think we are forced to keep resolve.conditions as is. I think we could merge this PR, and then try to replace both options with a better API later on.

[sapphi-red]

OK, let's merge this PR 👍