-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add typing to CSSOptions.preprocessorOptions
#18001
fix: add typing to CSSOptions.preprocessorOptions
#18001
Conversation
Run & review this pull request in StackBlitz Codeflow. |
CSSOptions.preprocessorOptions
CSSOptions.preprocessorOptions
CSSOptions.preprocessorOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added types for less and stylus and resolved the conflict.
I tested the built package with create-vite and it worked as expected.
/ecosystem-ci run |
📝 Ran ecosystem CI on
✅ astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress |
Speaking of optional peer deps, it looks like currently |
@hi-ogawa Yeah, I think we can do this for lightningcss too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this up sapphi!
39f96e0
Description
Fixes #17984. This adds optional type definition to
CSSOptions.preprocessorOptions
. Users who have installedsass
will see the correct types, while others will simply see it asany
: