fix(optimizer): support new Worker and new URL(..., import.meta.url) for pre-bundled dependencies
#17837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
commented
Aug 9, 2024
| const subUrl = new URL('./sub.js', import.meta.url) | ||
|
|
||
| export default () => import(subUrl) | ||
| export default () => import(/* @vite-ignore */ String('./sub.js')) |
There was a problem hiding this comment.
This case is now compatible, so I made it more "incompatible" for the tests added in #16080
Closed
7 tasks
hi-ogawa
changed the title
new Worker and new URL(..., import.meta.url) for pre-bundled dependenciesnew Worker and new URL(..., import.meta.url) for pre-bundled dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related #16418, #8427, #11672
I'm exploring
new URLandnew Workersupport for pre-bundled dependencies as a user land vite plugin (and mostly as a standalone esbuild plugin) in https://github.com/hi-ogawa/vite-plugins/tree/main/packages/pre-bundle-new-url. From what I tested on various examples, this seems to cover well known scenarios, so I'm starting with this draft PR to discuss whether this could be moved to core.The approach is based on 3rd one suggested in #16418 (comment). This intercept
onLoadhooks for all js files, so performance impact is one concern (there are other concerns too and I wrote them as TODO in the code).Some examples I tested are:
optimizeDeps.excludefor devthree-gpu-pathtraceris currently broken for vite build due to Build fails on self reference workernew Worker(new URL(..., import.meta.url))in dependency #17843I think the main question to ask first is whether we need to rash into supporting this on top of current esbuild. Maybe would it be better to suggest and test user land workaround (either simply
optimizeDeps.exclude, which users already see as a warning message, or my plugin) and wait for a bundler level support by esbuild or rolldown?Also regardless of whether waiting for esbuild or rolldown, it's probably important to guide their implementation so that it'll be directly usable for Vite. I made a bundler comparison table in https://github.com/hi-ogawa/reproductions/tree/main/webpack-new-url-worker-bundle-or-copy and it seems esbuild's future implementation (though it could be stale PR) might not match well with what Vite needs. If anyone has suggestions for what we can do right now, I'm curious to hear.