Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support circular dependency of harfbuzz-freetype #47

Closed
wants to merge 1 commit into from

Conversation

ebraminio
Copy link
Contributor

@ebraminio ebraminio commented Jan 19, 2018

Closes #37,

Obviously hacky, lets see what happens

@ebraminio
Copy link
Contributor Author

ebraminio commented Jan 19, 2018

Hmm. Does travis say harfbuzz installation is broken so freetype couldn't find it?

It shouldn't be the case as harfbuzz installation is OK on github.com/Microsoft/vcpkg, hmmm, lets try autotools.

@ebraminio ebraminio force-pushed the master branch 6 times, most recently from c32c401 to 54a7c20 Compare January 19, 2018 14:02
@ebraminio ebraminio changed the title Support circular depedency of harfbuzz-freetype Support circular dependency of harfbuzz-freetype Jan 19, 2018
@ebraminio ebraminio force-pushed the master branch 8 times, most recently from a5f6eca to f5c1090 Compare January 19, 2018 18:44
@ebraminio
Copy link
Contributor Author

Tried every combination, something is wrong on freetype finding of harfbuzz AFAICS.

@ebraminio ebraminio closed this Jan 19, 2018
@ebraminio
Copy link
Contributor Author

Not optimistic about this but lets open it for another round of tries and perhaps helps from others.

@ebraminio ebraminio force-pushed the master branch 10 times, most recently from 6757ba2 to 7861f81 Compare January 20, 2018 08:40
@ebraminio
Copy link
Contributor Author

Finally... it contains update of both harfbuzz and freetype and builds harfbuzz with autogen.sh first then freetype with cmake then harfbuzz with cmake. I tried every other solution with no success, I hope this one would be acceptable.

@ebraminio
Copy link
Contributor Author

ebraminio commented Mar 1, 2018

This has very little benefit, even Chrome don't have it right now https://bugs.chromium.org/p/chromium/issues/detail?id=694137 so lets close as it as it doesn't worth the complexity it brings.

@ebraminio ebraminio closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant