Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDL3, add SDL3_image #328

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

isage
Copy link
Contributor

@isage isage commented Feb 2, 2025

Note: sdl image no longer requires libpng/libjpeg and uses stb_image to load images and tiny_jpeg / miniz to save jpeg/png.

@isage isage marked this pull request as draft February 2, 2025 11:55
@isage
Copy link
Contributor Author

isage commented Feb 2, 2025

Lemme do some tests of stb_image vs libpng/libjpeg first

@isage isage marked this pull request as ready for review February 2, 2025 12:28
@isage
Copy link
Contributor Author

isage commented Feb 2, 2025

libpng / libjpeg:

10 JPEGS TOOK: 5128644 msec
10 PNGS TOOK: 4314961 msec

10 JPEGS TOOK: 5130477 msec
10 PNGS TOOK: 4313254 msec

10 JPEGS TOOK: 5132565 msec
10 PNGS TOOK: 4324340 msec


stb_image:

10 JPEGS TOOK: 6058681 msec
10 PNGS TOOK: 4984479 msec

10 JPEGS TOOK: 6055964 msec
10 PNGS TOOK: 4975862 msec

10 JPEGS TOOK: 6053126 msec
10 PNGS TOOK: 4979222 msec

stb_image is slower, so let's switch back to libpng/libjpeg
(it adds around 340kb vs stb_image, but we can live with that_

Disable stb_image
@d3m3vilurr d3m3vilurr merged commit 4b29218 into vitasdk:master Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants