Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nginx-mod-http-headers-more and Access-Control-Allow-Origin to nginx #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add nginx-mod-http-headers-more and Access-Control-Allow-Origin to nginx #2

wants to merge 7 commits into from

Conversation

helpse
Copy link

@helpse helpse commented Apr 18, 2018

Hey @vitalybe I believe we need this fix!

The call to OPTIONS http://{SERVER}/radio-stream/api/playlists is returning a 401 (Unauthorized) because of the CORS policy, from the browser.

Please let me know what you think.

@vitalybe
Copy link
Owner

Hey, thanks for the PR!

  1. Why do you need to call OPTIONS from the browser? The 2 use cases I have now, Desktop app and Android app aren't concerned with CORS.

  2. That's a lot of changes in the Dockerfile... Why all that is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helpse @vitalybe