Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Measure and EchoMeasure to add new measures and standardize existing ones #182

Merged

Conversation

nathanpainchaud
Copy link
Member

  • Standardize the units of values returned (and/or the documentation of the return value) for previous methods: surface_area, structure_area_split_by_endo_center_line, lv_base_width and lv_length. The units were chosen as ones values in the literature are typically reported in;
  • Add new EchoMeasure methods + test of the new measures on synthetic examples:
    • myo_thickness
    • curvature

@nathanpainchaud nathanpainchaud added the enhancement New feature or request label Nov 8, 2023
@nathanpainchaud nathanpainchaud self-assigned this Nov 8, 2023
@nathanpainchaud nathanpainchaud merged commit af24988 into vitalab:dev Nov 8, 2023
2 checks passed
@nathanpainchaud nathanpainchaud deleted the feature/new-echo-measures branch November 8, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant