-
-
Notifications
You must be signed in to change notification settings - Fork 385
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
style: use shared ESLint config (#1042)
* style: use shared ESLint config * docs: fix HTML errors * style: reformat * style: manual fixes Co-authored-by: Vis Bot <[email protected]>
- Loading branch information
Showing
221 changed files
with
212,963 additions
and
105,821 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,6 +137,7 @@ jobs: | |
| - attach_workspace: | ||
| at: .. | ||
|
|
||
| - run: npm run style | ||
| - run: npm run lint | ||
|
|
||
| test_unit: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,28 @@ | ||
| /* | ||
|
|
||
| !/*?.?* | ||
| !/.?*.?* | ||
|
|
||
| !/docs | ||
| !/docs-kr | ||
| !/src | ||
| !/test | ||
|
|
||
| !/cypress | ||
| /cypress/fixtures/**/*.js | ||
| /cypress/fixtures/**/*.js.map | ||
| /cypress/integration/**/*.js | ||
| /cypress/integration/**/*.js.map | ||
| /cypress/pages/**/*.js | ||
| /cypress/pages/**/*.js.map | ||
| /cypress/screenshots/ | ||
| /cypress/snapshots/ | ||
| /cypress/screenshots | ||
| /cypress/snapshots | ||
| /cypress/support/**/*.js | ||
| /cypress/support/**/*.js.map | ||
| /cypress/videos/ | ||
| /cypress/videos | ||
|
|
||
| !/examples | ||
| /examples/examples.css | ||
| /examples/index.html | ||
| /examples/static/ | ||
| /examples/thumbnails/ | ||
| /examples/static | ||
| /examples/thumbnails |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,120 +1,3 @@ | ||
| module.exports = { | ||
| env: { | ||
| "cypress/globals": true, | ||
| browser: true, | ||
| es6: true, | ||
| node: true, | ||
| mocha: true | ||
| }, | ||
|
|
||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| sourceType: "module", | ||
| ecmaVersion: 2020, | ||
| project: 'tsconfig.lint.json', | ||
| extraFileExtensions: [".json"], | ||
| }, | ||
|
|
||
| plugins: ["prettier", "@typescript-eslint", "cypress"], | ||
|
|
||
| extends: ['eslint:recommended', 'prettier'], | ||
|
|
||
| // For the full list of rules, see: http://eslint.org/docs/rules/ | ||
| rules: { | ||
| 'prettier/prettier': ['off'], | ||
| 'no-trailing-spaces': 'error', | ||
|
|
||
| complexity: ['error', 55], | ||
| "max-statements": ['error', 115], | ||
| "no-unreachable": 'warn', | ||
| "no-useless-escape": 'off', | ||
|
|
||
| "no-console": 'off', | ||
| // To flag presence of console.log without breaking linting: | ||
| //"no-console": ["warn", { allow: ["warn", "error"] }], | ||
|
|
||
| "require-jsdoc": ["error", { | ||
| require: { | ||
| FunctionDeclaration: true, | ||
| MethodDefinition: true, | ||
| ClassDeclaration: true, | ||
| ArrowFunctionExpression: false | ||
| } | ||
| }], | ||
| "valid-jsdoc": ['error', { | ||
| requireReturnDescription: false, | ||
| requireReturn: false, | ||
| requireParamDescription: false, | ||
| requireReturnType: true | ||
| }], | ||
| "guard-for-in": 'warn', | ||
|
|
||
| "no-var": "error", | ||
| "prefer-const": "error", | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: ['**/*.ts', '**/*.d.ts'], | ||
| rules: { | ||
| // @TODO: Seems to mostly work just fine but I'm not 100 % sure. | ||
| // @TODO: Deprecated, anything like this for tsdoc? | ||
| "valid-jsdoc": [ | ||
| "error", | ||
| { | ||
| prefer: { | ||
| arg: "param", | ||
| argument: "param", | ||
| return: "returns" | ||
| }, | ||
| requireParamDescription: true, | ||
| requireParamType: false, | ||
| requireReturn: false, // Requires return for void functions. | ||
| requireReturnDescription: true, | ||
| requireReturnType: false | ||
| } | ||
| ], | ||
|
|
||
| // Class related. | ||
| "@typescript-eslint/naming-convention": [ | ||
| "error", | ||
| { | ||
| selector: "memberLike", | ||
| modifiers: ["private", "protected"], | ||
| format: null, | ||
| leadingUnderscore: "require" | ||
| }, | ||
| { | ||
| selector: "memberLike", | ||
| modifiers: ["public"], | ||
| format: null, | ||
| leadingUnderscore: "forbid" | ||
| } | ||
| ], | ||
| "@typescript-eslint/no-parameter-properties": "off", | ||
| "@typescript-eslint/no-useless-constructor": "error", | ||
| "@typescript-eslint/prefer-readonly": "error", | ||
|
|
||
| // Other. | ||
| "@typescript-eslint/no-unnecessary-type-assertion": "error", | ||
| "@typescript-eslint/prefer-includes": "error", | ||
| "@typescript-eslint/prefer-regexp-exec": "error", | ||
| // @TODO: Seems like a good thing, not yet on npm though. | ||
| // "@typescript-eslint/require-await": "error", | ||
|
|
||
| // These are hoisted, I have no idea why it reports them by default. | ||
| "@typescript-eslint/no-use-before-define": [ | ||
| "error", | ||
| { functions: false, classes: false, typedefs: false } | ||
| ], | ||
| // False positives for overloading, also tsc compiles with errors anyway. | ||
| "no-dupe-class-members": "off", | ||
| // Blocks typesafe exhaustive switch (switch (x) { … default: const never: never = x }). | ||
| "no-case-declarations": "off", | ||
| // Reports used types. | ||
| "no-unused-vars": "off", | ||
| // Reports typeof bigint as an error, tsc validates this anyway so no problem turning this off. | ||
| "valid-typeof": "off" | ||
| } | ||
| }, | ||
| ] | ||
| extends: [require.resolve("vis-dev-utils/eslint-shareable-config")], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .eslintignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| branch: master | ||
| plugins: | ||
| - '@semantic-release/commit-analyzer' | ||
| - '@semantic-release/release-notes-generator' | ||
| - '@semantic-release/npm' | ||
| - '@semantic-release/github' | ||
| - "@semantic-release/commit-analyzer" | ||
| - "@semantic-release/release-notes-generator" | ||
| - "@semantic-release/npm" | ||
| - "@semantic-release/github" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.