Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS acceleration #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rstacruz
Copy link
Member

This makes move.js do hardware-accelerated transformations and scales on iOS devices.

This uses -webkit-transform: translate3d() and scale3d() in addition to translate() and scale().

One caveat: move().x(40).y(40) will now not produce the correct result. This will do add two translate3d's to the -webkit-transform property. This can be fixed, but I'm not sure on the cleanest way to do that right now...

Move.prototype.setVendorProperty = function(prop, val, options){
if ((!options) || (!options.noWebkit)) {
this.setProperty('-webkit-' + prop, val);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options = options || {};
if (!options.noWebkit){

would be easier to read

@ppcano
Copy link

ppcano commented Jan 10, 2012

@visionmedia, do you plan to include this pull request?

That fixs a problem ( suddenly, browser shows white screen ) when using continue animations on mobile devices.

Tested on ipad2.

@tj
Copy link
Member

tj commented Jan 10, 2012

i'll try it in a min, alot of the PRs have been breaking stuff

@tj
Copy link
Member

tj commented Jan 10, 2012

cant get it to apply cleanly

@jrok
Copy link

jrok commented May 9, 2012

Has this been completed now?

@ppcano
Copy link

ppcano commented May 10, 2012

@jrok, i don't know, but if it does not fit your case, you could also give a try to jquery.transit.

@jrok
Copy link

jrok commented May 10, 2012

Yeah, working with jquery transit now, was hoping to use move.js instead as its a little less complex. Caveat i guess is that its also a little less functional...thanks

@tj
Copy link
Member

tj commented May 10, 2012

@rstacruz I'd be happy to give you commit access to this repo if you want, too many projects now :D

@RaghavRamesh
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants