Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Sized numeric arrays #16

Merged
merged 1 commit into from
Aug 4, 2024
Merged

feat(types): Sized numeric arrays #16

merged 1 commit into from
Aug 4, 2024

Conversation

ibgreen
Copy link
Contributor

@ibgreen ibgreen commented Aug 4, 2024

Add NumericArray1-NumericArray16, as it is often useful to accept either a sized number array or a typed array (which can't be sized).

@ibgreen ibgreen requested a review from felixpalmer August 4, 2024 15:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10237430911

Details

  • 26 of 70 (37.14%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 84.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/types/src/array-types.ts 0 44 0.0%
Totals Coverage Status
Change from base Build 10232476638: -0.1%
Covered Lines: 14805
Relevant Lines: 17576
💛 - Coveralls

@ibgreen ibgreen merged commit 5aeef45 into master Aug 4, 2024
1 check passed
@ibgreen ibgreen deleted the ib/sized-numeric-arrays branch August 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibgreen @coveralls