Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit #40

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

first commit #40

wants to merge 7 commits into from

Conversation

edsu7
Copy link
Contributor

@edsu7 edsu7 commented Aug 13, 2024

Added

  • waste water schema
  • working tested data from calgary, ontario, quebec, alberta
  • errors from initial upload

Notes regarding schema

Notes regarding test data

  • all provinces
    • missing required isolate ID,read mapping software name,read mapping software version,sequenced by contact name, and sequencing instrument
    • need to add Influenza A to organism list

Things left to do

  • test field dependencies once conditional checks are enabled in lectern
  • fix incorrect displayNames
  • remove sequenced by

edsu7 added 7 commits August 13, 2024 08:49
- waste water schema
- working tested data from calgary, ontario, quebec, alberta
- errors from initial upload
    - remove unused lists
    - made lists w/ and w/out codes. Schema now references lists w/out codes
    - fixed typos in dependencies for `alkalinity measurement unit`,`alkalinity measurement value`,`quality control method version`
    - converted value fields to integers
    - added conditional checks
- fix ontology ID
- format references jsons
- remove lists.json file
- swapped dataTypes to `number` to support decimals
- added regex for `longitude` and `latitude`
- added new values to `organisms`
- added new restrictions to `gene name` according to `organism` selected in `organism`
- added new codeList to support `gene name` according to `organism`
- references to pepper mottle virus removed
- longitude and latitude regex simplified
- correct "values" to "value" as per overture-stack/lectern#235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant