Merge pull request #193 from virtualidentityag/fix/OB-10087-reset-pw-…

…fail fix: remove e2eeEnabled check
virtualidentityag · Feb 23, 2024 · 0d92204 · 0d92204
2 parents b2a8ab4 + 78d016e
commit 0d92204
Showing 1 changed file with 26 additions and 32 deletions.
diff --git a/src/components/passwordReset/PasswordReset.tsx b/src/components/passwordReset/PasswordReset.tsx
@@ -21,7 +21,6 @@ import { apiRocketChatSetUserKeys } from '../../api/apiRocketChatSetUserKeys';
 import { getValueFromCookie } from '../sessionCookie/accessSessionCookie';
 import {
 	AUTHORITIES,
-	E2EEContext,
 	hasUserAuthority,
 	UserDataContext
 } from '../../globalState';
@@ -60,8 +59,6 @@ export const PasswordReset = () => {
 	const [overlayActive, setOverlayActive] = useState(false);
 	const [isRequestInProgress, setIsRequestInProgress] = useState(false);
 
-	const { isE2eeEnabled } = useContext(E2EEContext);
-
 	const overlayItem: OverlayItem = {
 		svg: CheckIcon,
 		headline: translate(
@@ -213,25 +210,25 @@ export const PasswordReset = () => {
 			apiUpdatePassword(oldPassword, newPassword)
 				.then(async () => {
 					try {
-						if (isE2eeEnabled) {
-							// create new masterkey from newPassword
-							const newMasterKey =
-								await deriveMasterKeyFromPassword(
-									rcUid,
-									newPassword
-								);
-							// encrypt private key with new masterkey
-							const encryptedPrivateKey = await encryptPrivateKey(
-								sessionStorage.getItem('private_key'),
-								newMasterKey
-							);
-							// save with rocket chat
-							await apiRocketChatSetUserKeys(
-								sessionStorage.getItem('public_key'),
-								encryptedPrivateKey
-							);
-						}
-						// TODO Update masterkey in localstorage same logic as autoLogin
+						// always execute reset logic to ensure master key is updated even if E2ee is enabled or not
+
+						// create new masterkey from newPassword
+						const newMasterKey = await deriveMasterKeyFromPassword(
+							rcUid,
+							newPassword
+						);
+
+						// encrypt private key with new masterkey
+						const encryptedPrivateKey = await encryptPrivateKey(
+							sessionStorage.getItem('private_key'),
+							newMasterKey
+						);
+
+						// save with rocket chat
+						await apiRocketChatSetUserKeys(
+							sessionStorage.getItem('public_key'),
+							encryptedPrivateKey
+						);
 
 						isConsultant &&
 							featureAppointmentsEnabled &&
@@ -244,17 +241,14 @@ export const PasswordReset = () => {
 						setIsRequestInProgress(false);
 						logout(false, settings.urls.toLogin);
 					} catch (e) {
-						if (isE2eeEnabled) {
-							// rechange password to the old password
-							await apiUpdatePassword(
-								newPassword,
-								oldPassword
-							).catch(() => {
+						// rechange password to the old password
+						await apiUpdatePassword(newPassword, oldPassword).catch(
+							() => {
 								// if an error happens here we keep the newPassword but don't upgrade the masterKey
 								// and hope it works next login attempt
-							});
-							setHasMasterKeyError(true);
-						}
+							}
+						);
+						setHasMasterKeyError(true);
 
 						featureAppointmentsEnabled &&
 							apiUpdatePasswordAppointments(
@@ -334,7 +328,7 @@ export const PasswordReset = () => {
 					</div>
 				</div>
 
-				{isE2eeEnabled && hasMasterKeyError && (
+				{hasMasterKeyError && (
 					<div className="passwordReset__error">
 						{translate('profile.functions.masterKey.saveError')}
 					</div>