Caritas 243 remove legacy code #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removal of sendNewFeedbackMessageNotification api code
…SSAGE_FROM_ADVICE_SEEKER
…SSAGE_FROM_ADVICE_SEEKER
…SSAGE_FROM_ADVICE_SEEKER
# Conflicts: # src/main/java/de/caritas/cob/userservice/api/adapters/web/controller/UserController.java # src/test/java/de/caritas/cob/userservice/api/facade/EmailNotificationFacadeTest.java # src/test/java/de/caritas/cob/userservice/api/facade/sessionlist/SessionListFacadeTest.java # src/test/java/de/caritas/cob/userservice/api/service/sessionlist/ConsultantSessionEnricherTest.java # src/test/java/de/caritas/cob/userservice/api/service/sessionlist/ConsultantSessionListServiceTest.java
… main consultant logic
…erator and remove rcFeedbackGroupId from CreateEnquiryExceptionInformation
adapt isTeamSession method name
There was a problem hiding this comment.
hey @Leandro13Silva13, one comment regarding the sql-migrations and the question, how to remove the deleted properties in session.
...in/resources/db/changelog/changeset/0002_monitoringKeys_feedbackChatClumn/0002_changeSet.xml
Outdated
Show resolved
Hide resolved
.../caritas/cob/userservice/api/actions/session/SetRocketChatRoomReadOnlyActionCommandTest.java
Outdated
Show resolved
Hide resolved
.../java/de/caritas/cob/userservice/api/adapters/web/controller/UserControllerSessionE2EIT.java
Show resolved
Hide resolved
...itas/cob/userservice/api/admin/service/agency/RemoveConsultantFromRocketChatServiceTest.java
Show resolved
Hide resolved
...main/resources/db/changelog/changeset/0046_remove_feeback_related_columns/0046_changeSet.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
hey @Leandro13Silva13, its starting to get quite big ;)
Added some thoughts about the rollback of the removal.
If you want we can also talk about.
...log/changeset/0046_remove_feeback_related_columns/removeIs_peer_chatFromSession-rollback.sql
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/de/caritas/cob/userservice/api/admin/service/rocketchat/RocketChatGroupOperation.java # src/test/java/de/caritas/cob/userservice/api/admin/service/rocketchat/RocketChatRemoveFromGroupOperationServiceTest.java # src/test/java/de/caritas/cob/userservice/api/facade/assignsession/AssignEnquiryFacadeTest.java # src/test/java/de/caritas/cob/userservice/api/facade/assignsession/AssignSessionFacadeTest.java
Merge dev into this branch and fix merge issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.