fix: CARITAS-243

* remove userServiceApiSendNewFeedbackMessageNotificationUrl
virtualidentityag · Aug 9, 2024 · a63a538 · a63a538
1 parent fe0fb53
commit a63a538
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/src/main/java/de/caritas/cob/uploadservice/api/facade/EmailNotificationFacade.java b/src/main/java/de/caritas/cob/uploadservice/api/facade/EmailNotificationFacade.java
@@ -20,9 +20,6 @@ public class EmailNotificationFacade {
   @Value("${user.service.api.new.message.notification}")
   private String userServiceApiSendNewMessageNotificationUrl;
 
-  @Value("${user.service.api.new.feedback.message.notification}")
-  private String userServiceApiSendNewFeedbackMessageNotificationUrl;
-
   @Autowired
   public EmailNotificationFacade(
       EmailNotificationHelper emailNotificationHelper, AuthenticatedUser authenticatedUser) {

diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties
@@ -47,7 +47,6 @@ springfox.documentation.swagger.v2.path=${springfox.docuPath}/v2/api-docs
 # UserService API
 user.service.api.url=<containername>:<port>/users
 user.service.api.new.message.notification=${user.service.api.url}/mails/messages/new
-user.service.api.new.feedback.message.notification=${user.service.api.url}/mails/messages/feedback/new
 user.service.api.liveproxy.url=<containername>:<port>
 # CSRF token
 csrf.header.property=
@@ -107,4 +106,4 @@ management.endpoint.health.show-details=never
 management.endpoints.web.exposure.include=health
 management.health.probes.enabled=true
 management.metrics.mongo.command.enabled=false 
-management.metrics.mongo.connectionpool.enabled=false
+management.metrics.mongo.connectionpool.enabled=false
diff --git a/src/test/java/de/caritas/cob/uploadservice/api/facade/EmailNotificationFacadeTest.java b/src/test/java/de/caritas/cob/uploadservice/api/facade/EmailNotificationFacadeTest.java
@@ -24,10 +24,6 @@ public class EmailNotificationFacadeTest {
       "userServiceApiSendNewMessageNotificationUrl";
   private static final String NOTIFICATION_API_URL =
       "http://caritas.local/service/users/mails/messages/new";
-  private static final String FIELD_NAME_NEW_FEEDBACK_MESSAGE_NOTIFICATION =
-      "userServiceApiSendNewFeedbackMessageNotificationUrl";
-  private static final String FEEDBACK_NOTIFICATION_API_URL =
-      "http://caritas.local/service/users/mails/messages/feedback/new";
   private static final String RC_GROUP_ID = "fR2Rz7dmWmHdXE8uz";
 
   @Mock private EmailNotificationHelper emailNotificationHelper;
@@ -37,7 +33,6 @@ public class EmailNotificationFacadeTest {
   @Before
   public void setup() throws NoSuchFieldException, SecurityException {
     ReflectionTestUtils.setField(emailNotificationFacade, FIELD_NAME_NEW_MESSAGE_NOTIFICATION, NOTIFICATION_API_URL);
-    ReflectionTestUtils.setField(emailNotificationFacade, FIELD_NAME_NEW_FEEDBACK_MESSAGE_NOTIFICATION, FEEDBACK_NOTIFICATION_API_URL);
   }
 
   @Test