Branch/no model tick #473
Open
Branch/no model tick #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't any reason to delay execution. `kernel.tick` is still called exactly once per reflector tick. Also, don't bother advancing time after the last authorized action. Nothing executes at that time if it is between actions, so nothing will see it. This is in preparation for keeping tick messages out of the queue.
If the model sees individual tick messages, then unexecuted ticks are part of the application state. All ticks must pass through the message queue, and unexecuted ticks must be included in the replication and persistence data. This adds unnecessary bulk to the state data and can increase buffer delays during poor network conditions. It also prevents the reflector from ticking clients on slower networks at a slower rate. This commit interprets reflector ticks only as authorization to move kernel time forward. Ticks are no longer placed in the queue. `model.ticking` is no longer called on model drivers, and `node.tick` is no longer called for nodes providing a `tick` function. `view.ticked` is still called for view drivers since views don't affect the application state. View ticks are still called exactly once per reflector tick message. Nodes and model drivers that make use of tick messages will need to be updated. If necessary, the kernel may be able to insert `future` calls to provide backward compatability.
|
The previous PR is #450 on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of the branch/tickless-model without all of the merges. The changes from tickless-model were cherry-picked due to some strange issues with the merges/rebases.