RHEL-72207: Apply clang-format to ivshmem folder #1236
+674
−565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanVugenfirer
approved these changes
Dec 26, 2024
|
@Jedoku The PR has conflicts. Otherwise +1 |
Signed-off-by: Vitalii Chulak <[email protected]>
Jedoku
force-pushed
the
RHEL-72207-apply-clang-format-to-ivshmem-folder
branch
from
44cc664 to
5d2e002
Compare
YanVugenfirer
approved these changes
Dec 26, 2024
kostyanf14
requested changes
Dec 26, 2024
Comment on lines
176
to
178
| #if (NTDDI_VERSION >= NTDDI_WIN8) | ||
| result = MmAllocateMdlForIoSpace(&deviceContext->shmemAddr, 1, &deviceContext->shmemMDL); | ||
| result = MmAllocateMdlForIoSpace(&deviceContext->shmemAddr, 1, &deviceContext->shmemMDL); | ||
| #else |
There was a problem hiding this comment.
Looks like a part for refactoring. This condition can be removed as we drop Win8 support.
ivshmem/Device.c
Outdated
Comment on lines
228
to
238
| DEBUG_INFO("%s", "This driver does not support > 64 interrupts, they will be ignored in the ISR."); | ||
| DEBUG_INFO("%s", "This driver does not support > 64 interrupts, they will be ignored in the ISR."); |
ivshmem/Queue.c
Outdated
Comment on lines
259
to
260
| if (fileContext->shmemMap) | ||
| return STATUS_DEVICE_ALREADY_ATTACHED; |
ivshmem/test/ivshmem-test.cpp
Outdated
Comment on lines
307
to
312
| if (devHandle != INVALID_HANDLE_VALUE) | ||
| CloseHandle(devHandle); | ||
|
|
||
| if (infData) | ||
| free(infData); | ||
|
|
Jedoku
changed the title
|
s/clang-formatt/clang-format/ |
Signed-off-by: Vitalii Chulak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.