[vioscsi] Extend VioScsiReadRegistryParameter() #1216
Conversation
Adds capability to do per HBA registry reads. This permits, e.g. PhysicalBreaks_001, PhysicalBreaks_002, etc. as an alternative to \Parameters\Device(d) by instead using the format \Parameters\Device\Valuename_123. Includes FIXME NOTE regarding StorPortGetSystemPortNumber(). StorPortGetSystemPortNumber() should return before HBA-specific registry reads can successfully use \Parameters\Device(d). Coincidentally updated the following in VioScsiFindAdapter(): adaptExt->dump_mode (new tracing) adaptExt->hba_id (new tracing and new definition) The HBA ID that determines the "123" in Valuename_123 of the registry path \Parameters\Device\Valuename_123 is the HBA slot number minus 1. Signed-off-by: benyamin-codez <[email protected]>
|
If anyone knows how to get As we're using a SAS BusType, we might need to set the |
|
I was minded to think how this PR might be of benefit to the Jira issue you previously mentioned. Firstly, the issue mentions enabling SG_IO. You can probably speak best as to whether or not this would still work, as Anyway, as for this PR it would mean such disks could co-exist with disks of a variety of backing characteristics because each HBA could have it's own NOPB and MaximumTransferLength. The solution that I imagined, would require a PR for new NOPB calculations, like the one I mentioned here. The final part of the solution would be a PR for QEMU to set There's probably other ways to do it too - perhaps even solely on the driver side via VPD - but I believe this would require a HBA restart with new parameters rather than single init during Best regards, |
Addendum to 100af3e. 1. Removed references to obsoleted RUN_MIN_CHECKED definition (PR virtio-win#1228). 2. Add comment to conditionally excluded variable. Signed-off-by: benyamin-codez <[email protected]>
Adds capability to do per-HBA registry reads.
This permits, e.g.
PhysicalBreaks_001,PhysicalBreaks_002, etc.This is an alternative to
\Parameters\Device(d)by instead using the format\Parameters\Device\Valuename_123.Includes
FIXME NOTEregardingStorPortGetSystemPortNumber().StorPortGetSystemPortNumber()should return ......before HBA-specific registry reads can successfully use
\Parameters\Device(d).Coincidentally updated the following in
VioScsiFindAdapter():adaptExt->dump_mode(new tracing)adaptExt->hba_id(new tracing and new definition)The HBA ID that determines the "123" in
Valuename_123of ......the registry path
\Parameters\Device\Valuename_123is the HBA slot number minus 1.