Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snphost CI PR test #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LakshmiSaiHarika
Copy link

Performs snphost cargo tests on the self-hosted runner

@larrydewey
Copy link
Contributor

Looks like you have a linting error @LakshmiSaiHarika

@LakshmiSaiHarika LakshmiSaiHarika force-pushed the main branch 2 times, most recently from 198fe39 to 9dd8737 Compare November 14, 2024 19:50
@LakshmiSaiHarika
Copy link
Author

Hi Reviewers, I edited this PR to add manual PR event and did some code cleanup.

Please review this and let me know if any additional changes are required.

runs-on: self-hosted
steps:
- name: Checkout Repository
uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses: actions/checkout@v3


- name: Run snphost cargo test on the host
run: |
# Check and install dependencies on the host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -e # exit immediately on error and fail fast


# Cleanup steps on the host
rm -rf ~/snphost
cd ~/
Copy link
Contributor

@AdithyaKrishnan AdithyaKrishnan Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir -p ~/snphost
cd ~


if [ ${{ github.event_name }} == "pull_request_target" ]; then
event_pr_number=${{ github.event.pull_request.number }}
event_pr_branch=${{ github.head_ref }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.head_ref -> github.event.pull_request.head.ref

@LakshmiSaiHarika LakshmiSaiHarika force-pushed the main branch 3 times, most recently from e62617b to 25632fc Compare November 20, 2024 03:57
Contains all the required function definitions for its use in snphost CI PR workflow.

Signed-off-by: Harika Nittala <[email protected]>
Added snphost CI PR test workflow to perform snphost cargo tests on the self-hosted runner for a new PR, updated PR or after SNP kernel update on the self-hosted runner

Signed-off-by: Harika Nittala <[email protected]>
@LakshmiSaiHarika
Copy link
Author

LakshmiSaiHarika commented Nov 21, 2024

I addressed the above comments.... Please let me know if any changes are required

Copy link
Contributor

@AdithyaKrishnan AdithyaKrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @LakshmiSaiHarika

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants