Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the KeyInfo field into the attestation report #259

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

DGonzalezVillal
Copy link
Member

Since version 2 of the attestation report, instead of having just the AUTHOR_KEY_EN fIELD in the attestation report, the report now offers more data around the signature and the key being used in the attestation report. This PR extends that field and makes it accessible in the attestation report.

(This has been in the spec since sept 2023, unrelated to upcoming changes)

Since version 2 of the attestation report, instead of having just the
AUTHOR_KEY_EN fIELD in the attestation report, the report now offers
more data around the signature and the key being used in the attestation
report. This PR extends that field and makes it accessible in the
attestation report.

Signed-off-by: DGonzalezVillal <[email protected]>
Copy link
Contributor

@larrydewey larrydewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tylerfanelli
Copy link
Member

KeyInfo is still represented as a u32, so this is fine. Thanks for this.

@tylerfanelli tylerfanelli merged commit 18ed5c5 into virtee:main Dec 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants