Updating Errors to correctly use SEV API errors #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGonzalezVillal
requested review from
tylerfanelli and
larrydewey
as code owners
larrydewey
requested changes
Sep 11, 2024
DGonzalezVillal
force-pushed
the
firmware-error
branch
3 times, most recently
from
38eaae9 to
1e2c9b6
Compare
larrydewey
reviewed
Sep 12, 2024
DGonzalezVillal
force-pushed
the
firmware-error
branch
5 times, most recently
from
a65351a to
fcfe3ed
Compare
…TL calls to bubble correct errors The AMD PSP provides defined SEV errors in the API with clear codes and mistakes. The library currently only bubbles up IO errors and not the correct SEV error when IOCTL calls fail. This commit rearranges the error file to use SEV errors correctly, and then changes the way IOCTL calls returns errors, so that the appropriate SEV error is bubbled up when an error is encountered. Guest IOCTL calls do not fail the same way host IOCTLS do. You need to manually check for failures even if the ioctl function itself might not return an error. Signed-off-by: DGonzalezVillal <[email protected]>
DGonzalezVillal
force-pushed
the
firmware-error
branch
from
fcfe3ed to
33bf7c0
Compare
|
@larrydewey can you re-review? |
larrydewey
approved these changes
Oct 28, 2024
tylerfanelli
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMD PSP provides defined SEV errors in the API with clear codes and mistakes. The library currently only bubbles up IO errors and not the correct SEV error when IOCTL calls fail. This commit rearranges the error file to use SEV errors correctly, and then changes the way IOCTL calls returns errors, so that the appropriate SEV error is bubbled up when an error is encountered.