Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meson build to specify python #223

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Aug 25, 2024

  • Chores
    • Updated the project version retrieval method to specify the Python interpreter, enhancing compatibility across different environments.

Signed-off-by: Sammy Oina <[email protected]>
@SammyOina SammyOina changed the title fix command Update meson build to specify python Aug 25, 2024
@SammyOina SammyOina marked this pull request as ready for review August 25, 2024 21:36
@auto-assign auto-assign bot requested a review from ryansavino August 25, 2024 21:36
@tylerfanelli
Copy link
Member

tylerfanelli commented Aug 26, 2024

Is there an existing bug with the previous way of doing this? I haven't had a problem.

@SammyOina
Copy link
Contributor Author

Is there an existing bug with the previous way of doing this? I haven't had a problem.

when I perform meson setup i get the following error:

meson setup builddr
The Meson build system
Version: 1.5.1
Source dir: /home/sammyk/Documents/sev-f
Build dir: /home/sammyk/Documents/sev-f/builddr
Build type: native build

meson.build:4:12: ERROR: Program or command './package-version.py' not found or not executable

A full log can be found at /home/sammyk/Documents/sev-f/builddr/meson-logs/meson-log.txt

not sure if this the same way you run it.

@tylerfanelli
Copy link
Member

LGTM. @larrydewey can you review?

@tylerfanelli tylerfanelli merged commit 8ce9b6e into virtee:main Sep 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants