-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing commands #7
base: main
Are you sure you want to change the base?
Conversation
Nice, thanks for the contribution! I will take a look once you request a review :). |
@derpsteb this is ready for review |
Sorry I was away from my laptop for a few weeks. Will pick this up on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, went over the bigger part, looks great so far! need to finish the rest tomorrow. only some small comments.
one thing missing is some e2e test for the added functionality. but I think this needs to be done in CI because we need to build ovmf and svsm binaries for that. maybe you can have a look at upstream_test.go
- if you have a good idea how to build a similar test for some of the new features it would be much appreciated. (the ovmf.New
call in upstream_test.go
also needs to be fixed.)
one general thing: could you see that the contents of a file are ordered like this?
- Constants and variables
- Exported functions
- Exported types followed by their new funcs, exported methods, and unexported methods, i.e.
- Unexported functions
- Unexported types and their methods
I will mention this expectation in the readme for future contributions.
thanks again for your work.
return VMSA_SVSM{SaveArea: saveArea}, nil | ||
} | ||
|
||
func BuildSaveAreaSVSM(eip uint32, sevFeatures uint64, vcpuSig uint64, vmmType vmmtypes.VMMType) (SevEsSaveArea, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func BuildSaveAreaSVSM(eip uint32, sevFeatures uint64, vcpuSig uint64, vmmType vmmtypes.VMMType) (SevEsSaveArea, error) { | |
func (VMSA_SVSM) BuildSaveArea(eip uint32, sevFeatures uint64, vcpuSig uint64, vmmType vmmtypes.VMMType) (SevEsSaveArea, error) { |
the original BuildSaveArea
should also be a method of VMSA
. but I can do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave that for another PR
SevFeatures: sevFeatures, | ||
Xcr0: 0x1, | ||
Mxcsr: mxcsr, | ||
X87Fcw: fcw, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the original code is referencing a field fcw
here. but I can't find it in SevEsSaveArea
. Could you make sense of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see where it was used outside the package but the value is saved on x87Fcw
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
6b0d623
to
93054af
Compare
New Features
Improvements
Bug Fixes
Documentation