Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email #325

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Remove email #325

merged 6 commits into from
Oct 30, 2024

Conversation

Robin5605
Copy link
Contributor

Closes #324

@Robin5605 Robin5605 requested review from a team as code owners October 6, 2024 01:45
@Robin5605 Robin5605 force-pushed the remove-email branch 2 times, most recently from e27e92c to c1fd7ab Compare October 6, 2024 02:08
AbooMinister25
AbooMinister25 previously approved these changes Oct 9, 2024
Copy link
Contributor

@AbooMinister25 AbooMinister25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

src/mainframe/endpoints/report.py Outdated Show resolved Hide resolved
Additional information is required when using the Observation API.
The tests that used to validate the presence for additional information
when we used email have been removed. Docstrings have also been updated.
Copy link
Contributor

@AbooMinister25 AbooMinister25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Robin5605 Robin5605 merged commit 5f203df into main Oct 30, 2024
8 checks passed
@Robin5605 Robin5605 deleted the remove-email branch October 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove reporting by email
3 participants