-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migrations to make DB datetimes tz aware #266
Open
Robin5605
wants to merge
2
commits into
main
Choose a base branch
from
robin/patch/make-datetimes-tz-aware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sid-maddy
requested changes
Jul 14, 2024
sid-maddy
reviewed
Jul 14, 2024
jonathan-d-zhang
force-pushed
the
robin/patch/make-datetimes-tz-aware
branch
2 times, most recently
from
August 4, 2024 21:39
2579baf
to
2ab746b
Compare
up migration
down migration:
|
jonathan-d-zhang
force-pushed
the
robin/patch/make-datetimes-tz-aware
branch
from
August 4, 2024 21:56
2ab746b
to
502ec9d
Compare
Our models expect the datetimes to be timezone aware, however the database itself has timezone unaware datetimes. This should reconcile that by adding a migration to make the database timezones to be datetime aware.
jonathan-d-zhang
force-pushed
the
robin/patch/make-datetimes-tz-aware
branch
from
August 4, 2024 22:08
502ec9d
to
80fa49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our models expect the datetimes to be timezone aware, however the database itself has timezone unaware datetimes. This should reconcile that by adding a migration to make the database timezones to be datetime aware.