Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reauth race condition #50

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Reauth race condition #50

merged 3 commits into from
Jul 31, 2023

Conversation

jonathan-d-zhang
Copy link
Contributor

We really should be using only 1 thread for IO but this should work for now until robin cooks up another rewrite.

Closes #26

@jonathan-d-zhang jonathan-d-zhang added the bug Something isn't working label Jul 30, 2023
@jonathan-d-zhang jonathan-d-zhang self-assigned this Jul 30, 2023
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
Robin5605
Robin5605 previously approved these changes Jul 30, 2023
Copy link
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs lints to be fixed and needs main merged into this branch

Copy link
Contributor

@Robin5605 Robin5605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-d-zhang jonathan-d-zhang merged commit 887300b into main Jul 31, 2023
8 checks passed
@jonathan-d-zhang jonathan-d-zhang deleted the reauth-race-condition branch July 31, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reauthentication Race Condition
2 participants