Publication 2.3.7 (#70)

* Removed exceptions showed to enduser

Controller/Payment/Fallback.php

@@ -38,6 +38,7 @@
 use Vipps\Payment\Api\QuoteRepositoryInterface;
 use Vipps\Payment\Gateway\Command\PaymentDetailsProvider;
 use Vipps\Payment\Gateway\Transaction\Transaction;
+use Vipps\Payment\Model\Exception\AcquireLockException;
 use Vipps\Payment\Model\Gdpr\Compliance;
 use Vipps\Payment\Model\TransactionProcessor;
 use Vipps\Payment\Gateway\Exception\VippsException;
@@ -153,6 +154,9 @@ public function execute()
             $this->logger->critical($this->enlargeMessage($e));
             $this->messageManager->addErrorMessage($e->getMessage());
             $resultRedirect->setPath('checkout/onepage/failure', ['_secure' => true]);
+        } catch (AcquireLockException $e) {
+            $this->logger->critical($e->getMessage());
+            $resultRedirect->setPath('checkout/onepage/failure', ['_secure' => true]);
         } catch (\Exception $e) {
             $this->logger->critical($this->enlargeMessage($e));
             $this->messageManager->addErrorMessage(

Model/Exception/AcquireLockException.php

@@ -0,0 +1,27 @@
+<?php
+/**
+ * Copyright 2018 Vipps
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated
+ * documentation files (the "Software"), to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software,
+ * and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED
+ * TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON INFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
+ * CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+namespace Vipps\Payment\Model\Exception;
+
+/**
+ * Aims to mark acquire lock exception in a code to have custom processing
+ *
+ * Class AcquireLockException
+ * @package Vipps\Payment\Model\Exception
+ */
+class AcquireLockException extends \Exception
+{
+}

Model/TransactionProcessor.php

@@ -41,6 +41,7 @@
 use Vipps\Payment\Gateway\Transaction\Transaction;
 use Vipps\Payment\Gateway\Exception\WrongAmountException;
 use Vipps\Payment\Model\Adminhtml\Source\PaymentAction;
+use Vipps\Payment\Model\Exception\AcquireLockException;
 use Vipps\Payment\Model\Method\Vipps;
 
 /**
@@ -160,6 +161,7 @@ public function __construct(
      * @throws NoSuchEntityException
      * @throws VippsException
      * @throws WrongAmountException
+     * @throws AcquireLockException
      * @throws \Exception
      */
     public function process(QuoteInterface $vippsQuote, Transaction $transaction)
@@ -269,6 +271,7 @@ private function processAction($action, OrderInterface $order, Transaction $tran
      * @return string
      * @throws AlreadyExistsException
      * @throws InputException
+     * @throws AcquireLockException
      * @throws \Exception
      */
     private function acquireLock($reservedOrderId)
@@ -277,7 +280,7 @@ private function acquireLock($reservedOrderId)
         if ($reservedOrderId && $this->lockManager->lock($lockName, 10)) {
             return $lockName;
         }
-        throw new \Exception(__('Can not acquire lock for order "%1"', $reservedOrderId)); //@codingStandardsIgnoreLine
+        throw new AcquireLockException(__('Can not acquire lock for order "%1"', $reservedOrderId)); //@codingStandardsIgnoreLine
     }
 
     /**

composer.json

@@ -3,7 +3,7 @@
     "type": "magento2-module",
     "description": "Vipps Payment Method",
     "license": "proprietary",
-    "version": "2.3.6",
+    "version": "2.3.7",
     "require": {
         "magento/framework": "102.0.*",
         "magento/module-sales": "102.0.*",