Remove RoutineName, fix and test rowcount #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfava
commented
Dec 18, 2024
| grant create type to [sqlcode-deploy-role]; | ||
|
|
||
|
|
||
| alter user |
There was a problem hiding this comment.
The alter user by itself is not valid SQL. I'm not sure why it was here in the first place. My feeling is that this file was never properly tested/migrated before.
dfava
commented
Dec 18, 2024
| procNameToken := Unparsed{ | ||
| Type: OtherToken, | ||
| RawValue: fmt.Sprintf(templateRoutineName, strings.Trim(result.QuotedName.Value, "[]")), | ||
| /* |
There was a problem hiding this comment.
Leaving as a comment because the idea of having RoutineName is good. But we need to figure out what is going on with rowcount first.
dfava
commented
Dec 18, 2024
sqltest/sqlcode_test.go
Outdated
There was a problem hiding this comment.
Note that to run this (or any test in sqlcode), you need to add SQLSERVER_DSN as environment variable.
dfava
changed the title
theophanemayaud
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoutineName was something I added as a convenience, so we could, for example, do:
select _log=info, routine=@RoutineName, ...and not have to copy paste the routine name.But somehow the RoutineName feature changed the number of
@@rowcount. So I'm commenting out the RoutineName change (which was not used anyway). Fixing the rowcount and we can revisit RoutineName in the future.