Make the HTTP bind interface configurable #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vakaras , could you please post an update whether this PR is still useful for you? If yes, could you please explain in a few words what the purpose of TimingLog is that is extensively used in the PR. Otherwise, I'm happy to merge it. |
|
As far as I understand, this was needed for benchmarking Viper tools. @alexanderjsummers was the supervisor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ViperServer in Docker I need to connect to it from another container. For this to work, ViperServer must allow connecting from non-localhost IPs. This patch allows that as a command line option. The default behavior is unchanged.