Possible solution for transparently passing in zeroth argument #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've realized I don't check the lstat return value, but it could fail. That will have to be addressed, I will update the code at most during tomorrow. |
Rutherther
force-pushed
the
fix/transparent-zeroth-argument
branch
from
48ce746
to
21d6b69
Compare
Fixed, hopefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible fix for #4. Passes in zeroth argument with path to the shell the shell file is a link to, Additionally, if the zeroth argument to noshell starts with
-, it's passed through.This still has one issue, though. For example, when using home-manager to put the symlink, with
xdg.configFile.shell.source = lib.getExe pkgs.zsh;, the actual link is going to be from nix store home-manager files. I am not sure what the best solution for this is. One would be to just get the final filename withrealpath, but that has other issues - if one indeed wanted to emulate bash with symlinkingzshtobash, you will not get that behavior aszshwill be the zeroth argument!