Return with exit code when --ask is not accepted #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeidnx
force-pushed
the
exit_code
branch
3 times, most recently
from
bab871d
to
07d05b7
Compare
viperML
reviewed
Aug 25, 2024
|
I've made the requested change and also split the changes into two commits. |
|
Can you apply the same src/home.rs and src/clean.rs? Then it should be ready |
|
Of course, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exits the program with code 1 when the user rejects changing to the new configuration. The motivation behind this change is to make it easier to wrap this program in scripts.
As i have written in the code, i wanted to propagate the error properly but with color_eyre this doesn't seem to be an option.
I was also a bit confused what
drop(out_dir)was doing there and couldn't understand the comment, so i changed it to something more clear.