Merge pull request #25 from viordash/settings

skipping errors when entering msdn parameters
viordash · Oct 1, 2023 · 75438fb · 75438fb
2 parents 4cb7924 + c7c5f58
commit 75438fb
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/ShareClipbrd/ShareClipbrd.Core.Tests/Services/AddressResolverTests.cs b/ShareClipbrd/ShareClipbrd.Core.Tests/Services/AddressResolverTests.cs
@@ -1,5 +1,4 @@
-using ShareClipbrd.Core.Helpers;
-using ShareClipbrd.Core.Services;
+using ShareClipbrd.Core.Services;
 
 namespace ShareClipbrd.Core.Tests.Services {
     public class AddressResolverTests {
@@ -23,11 +22,11 @@ public void UseAddressDiscoveryService_When_Invalid_Address_Return_False() {
             Assert.That(id, Is.Empty);
             Assert.That(mandatoryPort, Is.Null);
 
-            Assert.IsFalse(AddressResolver.UseAddressDiscoveryService("mdns:", out id, out mandatoryPort));
+            Assert.IsFalse(AddressResolver.UseAddressDiscoveryService("mdns :", out id, out mandatoryPort));
             Assert.That(id, Is.Empty);
             Assert.That(mandatoryPort, Is.Null);
 
-            Assert.IsFalse(AddressResolver.UseAddressDiscoveryService("mdns:   ", out id, out mandatoryPort));
+            Assert.IsFalse(AddressResolver.UseAddressDiscoveryService("mdns :   ", out id, out mandatoryPort));
             Assert.That(id, Is.Empty);
             Assert.That(mandatoryPort, Is.Null);
         }
@@ -58,7 +57,17 @@ public void UseAddressDiscoveryService_When_Invalid_Ports_Throws_ArgumentExcepti
             Assert.Throws<ArgumentException>(() => AddressResolver.UseAddressDiscoveryService("mdns:abcde:-1", out id, out mandatoryPort));
             Assert.Throws<ArgumentException>(() => AddressResolver.UseAddressDiscoveryService("mdns:abcde:65536", out id, out mandatoryPort));
 
-            Assert.IsFalse(AddressResolver.UseAddressDiscoveryService("mdns::1", out id, out mandatoryPort));
+            Assert.IsTrue(AddressResolver.UseAddressDiscoveryService("mdns::1", out id, out mandatoryPort));
+            Assert.That(id, Is.Empty);
+            Assert.That(mandatoryPort, Is.Null);
+        }
+
+        [Test]
+        public void UseAddressDiscoveryService_Returns_True_And_Empty_Id_If_Address_Is_Not_Fully_Filled() {
+            string id;
+            int? mandatoryPort;
+
+            Assert.IsTrue(AddressResolver.UseAddressDiscoveryService("mdns:", out id, out mandatoryPort));
             Assert.That(id, Is.Empty);
             Assert.That(mandatoryPort, Is.Null);
         }

diff --git a/ShareClipbrd/ShareClipbrd.Core/Services/AddressResolver.cs b/ShareClipbrd/ShareClipbrd.Core/Services/AddressResolver.cs
@@ -38,7 +38,6 @@ public static bool UseAddressDiscoveryService(string address, out string id, out
             if(string.IsNullOrEmpty(s)) {
                 id = string.Empty;
                 mandatoryPort = null;
-                return false;
             }
             id = s;
             return true;

diff --git a/ShareClipbrd/ShareClipbrd.Core/Services/DataClient.cs b/ShareClipbrd/ShareClipbrd.Core/Services/DataClient.cs
@@ -82,6 +82,9 @@ public async Task SendFileDropList(StringCollection fileDropList) {
             var cancellationToken = cts.Token;
             try {
                 await Connect(cancellationToken);
+                if(!IsSocketConnected(client.Client)) {
+                    return;
+                }
                 var stream = await Handshake();
                 var fileTransmitter = new FileTransmitter(progressService, stream);
                 await fileTransmitter.Send(fileDropList, cancellationToken);
@@ -125,6 +128,9 @@ public async Task SendData(ClipboardData clipboardData) {
             var cancellationToken = cts.Token;
             try {
                 await Connect(cancellationToken);
+                if(!IsSocketConnected(client.Client)) {
+                    return;
+                }
                 await using(progressService.Begin(ProgressMode.Send)) {
                     var totalLenght = clipboardData.GetTotalLenght();
                     progressService.SetMaxTick(totalLenght);
@@ -190,6 +196,9 @@ async Task Connect(CancellationToken cancellationToken) {
                     if(mandatoryPort.HasValue) {
                         throw new ArgumentException("mdns port for the partner address is not needed");
                     }
+                    if(string.IsNullOrEmpty(id)) {
+                        return;
+                    }
                     ipEndPoint = await addressDiscoveryService.Discover(id);
                 } else {
                     ipEndPoint = NetworkHelper.ResolveHostName(systemConfiguration.PartnerAddress);