Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eve comment at the end of file, not beginning #17

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

joklek-vinted
Copy link
Contributor

Because eve adds comments on the first line, it's not obvious where the trouble happens. All of these comments are related to the end of file being incorrect, therefore I suggest to add the comment at the end of file.

@vinted/backend-technologies

Copy link

@mantaskujalis mantaskujalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do version bump too

@joklek-vinted joklek-vinted merged commit 65716f5 into master Jul 11, 2024
2 checks passed
@joklek-vinted joklek-vinted deleted the joklek-vinted-patch-1 branch July 11, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants