reduce n+1 queries and fix specs #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-mittal
force-pushed
the
reduce_queries_on_store_product_show_page
branch
2 times, most recently
from
7248a10
to
3dabbeb
Compare
vinay-mittal
force-pushed
the
reduce_queries_on_store_product_show_page
branch
from
3dabbeb
to
576dff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce 3 sets of n+1 queries by eagerloading
viewable,prices,stock_itemsassociations for variants on frontend product show page.Also fixed specs for the above and added specs for added associations.