Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing references #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Missing references #5

wants to merge 1 commit into from

Conversation

BenjaminP7
Copy link
Contributor

No description provided.

Copy link
Member

@vinothkannans vinothkannans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the two places I mentioned here.

if ($this->users == null) {
$this->users = new Users($this);
}
return $this->categories;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. it must be return $this->users;


public function user($id)
{
$user = new User($this, $id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently User can be only initialized with $username like below

$user = new User($this, $username);

@vinothkannans
Copy link
Member

anyway thanks for your valuable contributions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants