-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Novo layout do cartão de crédito na página de checkout #138
Merged
thalita-nascimento-vindi
merged 22 commits into
vindi:development
from
bizcommerce:development
Jan 9, 2025
Merged
Novo layout do cartão de crédito na página de checkout #138
thalita-nascimento-vindi
merged 22 commits into
vindi:development
from
bizcommerce:development
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development merge
Criação de link de pagamento (vindi#130)
Versão 2.1.0
Development
Feat/new card layout
thalita-nascimento-vindi
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testes realizados com sucesso.
leonardo-silva-vindi
approved these changes
Jan 8, 2025
This was referenced Jan 14, 2025
Merged
thalita-nascimento-vindi
added a commit
that referenced
this pull request
Jan 14, 2025
* Versionamento da 2.1.0 (#134) * Link de Pagamento - Cancelamento de Pedido (#136) * fix: add 'view/base/web/images/cc' images * feat: adding information message when deleting credit card * feat: add translate payment * feat: committing the features of the functionality in general * fix: error with null * fix: unify settings on menu * fix: unify settings on menu * feat: Adding validation on the card success page * feat: add delete payment link cron * fix: returning composer to version '1.4.0' * fix: delete payment link argument * fix: correction of method names in the template * fix: adjusting BillPaid webhook flow for when it is subscription and when it is not * fix: correction when searching for customer data in purchases with pix in Model/Payment/Customer.php * fix: PLANOS (1) * fix: PLANOS (1) - quantidade de periodos vazio * fix: PLANOS (2) - correcao de labels e quantidade de ate 31 dias * fix: PLANOS (3) e (4) - ajuste na edicao de planos importados * fix: PRODUTOS (1) e (2) - ajuste de cadastro de planos ao salvar produtos * fix: - PRODUTOS (3) - removendo cache do campo observacoes * fix: ASSINATURAS (2) - ajuste ao refazer pedidos de assinatura * fix: ASSINATURAS (1) - correcao na aplicacao de descontos * fix 2: PLANOS (3) e (4) - ajuste na edicao de planos importados * fix: PLANOS - ajustes ao salvar configuracao da cobranca * fix 2: PLANOS (1) - quantidade de periodos vazio * fix: METODOS DE PAGAMENTO - correcao ao habilitar/desabilitar compras com recorrencia * fix: CHECKOUT - duplicacao de mensagens * fix: PLANOS adicionando ID ao code * fix: PRODUTO - adicionando filtro no preco para valores maiores que zero * fix: PLANOS - ajuste no code * fix: CHECKOUT - compra como convidado * fix: ASSINATURAS - ajuste na exibicao dos detalhes da assinatura * fix: LOGS - aplicacao de mascara no CVV e no registry_code * fix: PRODUTOS - exibicao de mensagem no carrinho * feat: show discount at checkout and redirect customer to home page if link expires * fix: LOG - refatoracao nas expressoes regulares * fix: CHECKOUT - ajuste na url do boleto na renovacao de ciclo de assinatura * fix: ajuste da label do botao de criar e enviar novo link de pagamento * refactor: ajustando codigo para validacao do PHPStan * VINDI-158: estilizacao paginas link de pagamento e sucesso * Retorna arquivos comitados por engano * feat: vindi payment link module * fix: remove delete payment link after first access * feat: frontend development * fix: fix error Block/InfoTrait.php * fix: pay now color * feat: login is required, columns in the grid in the admin and frontend * feat: mass action send payment link email * feat: create payment link status * fix: add status validation in mass payment link send * fix: change link payment expiration time for 20 days * fix: update expired link * fix: change paid to processed status * fix: creating email trigger config * fix: changing the instruction label on the payment link success page * fix: setting a default template if none is selected * fix: name in from customer template * feat: add transtale * feat: adding access to the payment link also within the order * fix: change the link status if the order is canceled and it has not yet been changed * refactor: readjusting features to test them better * changing the version to 2.1.0 * feat: mass sending of emails in the order grid * feat: cancel order if payment link not processed * fix: save payment additionoal information in saved card * fix: version * refactor: change translate * fix: remove version in composer.json * feat: when invoicing orders, payments are processed * refactor: line comment * fix: plan form format --------- Co-authored-by: Iago Cedran <[email protected]> Co-authored-by: Thiago Contardi <[email protected]> Co-authored-by: Caroline Esteves <[email protected]> * Link de Pagamento - Template de Email (#137) * feat: adding information message when deleting credit card * feat: add translation * feat: add translate payment * feat: committing the features of the functionality in general * fix: error with null * fix: unify settings on menu * fix: unify settings on menu * feat: Adding validation on the card success page * feat: add delete payment link cron * fix: returning composer to version '1.4.0' * fix: delete payment link argument * fix: correction of method names in the template * fix: adjusting BillPaid webhook flow for when it is subscription and when it is not * fix: correction when searching for customer data in purchases with pix in Model/Payment/Customer.php * fix: PLANOS (1) * fix: PLANOS (1) - quantidade de periodos vazio * fix: PLANOS (2) - correcao de labels e quantidade de ate 31 dias * fix: PLANOS (3) e (4) - ajuste na edicao de planos importados * fix: PRODUTOS (1) e (2) - ajuste de cadastro de planos ao salvar produtos * fix: - PRODUTOS (3) - removendo cache do campo observacoes * fix: ASSINATURAS (2) - ajuste ao refazer pedidos de assinatura * fix: ASSINATURAS (1) - correcao na aplicacao de descontos * fix 2: PLANOS (3) e (4) - ajuste na edicao de planos importados * fix: PLANOS - ajustes ao salvar configuracao da cobranca * fix 2: PLANOS (1) - quantidade de periodos vazio * fix: METODOS DE PAGAMENTO - correcao ao habilitar/desabilitar compras com recorrencia * fix: CHECKOUT - duplicacao de mensagens * fix: PLANOS adicionando ID ao code * fix: PRODUTO - adicionando filtro no preco para valores maiores que zero * fix: PLANOS - ajuste no code * fix: CHECKOUT - compra como convidado * fix: ASSINATURAS - ajuste na exibicao dos detalhes da assinatura * fix: LOGS - aplicacao de mascara no CVV e no registry_code * fix: PRODUTOS - exibicao de mensagem no carrinho * feat: show discount at checkout and redirect customer to home page if link expires * fix: LOG - refatoracao nas expressoes regulares * fix: CHECKOUT - ajuste na url do boleto na renovacao de ciclo de assinatura * fix: ajuste da label do botao de criar e enviar novo link de pagamento * refactor: ajustando codigo para validacao do PHPStan * VINDI-158: estilizacao paginas link de pagamento e sucesso * Retorna arquivos comitados por engano * feat: vindi payment link module * fix: remove delete payment link after first access * feat: frontend development * fix: fix error Block/InfoTrait.php * fix: pay now color * feat: login is required, columns in the grid in the admin and frontend * feat: mass action send payment link email * feat: create payment link status * fix: add status validation in mass payment link send * fix: change link payment expiration time for 20 days * fix: update expired link * fix: change paid to processed status * fix: creating email trigger config * fix: changing the instruction label on the payment link success page * fix: setting a default template if none is selected * fix: name in from customer template * feat: add transtale * feat: adding access to the payment link also within the order * fix: change the link status if the order is canceled and it has not yet been changed * refactor: readjusting features to test them better * changing the version to 2.1.0 * feat: mass sending of emails in the order grid * feat: cancel order if payment link not processed * feat: add template email by config * fix: save payment additionoal information in saved card * fix: version * fix: adjusting link access correction * refactor: change translate * fix: remove version in composer.json * feat: when invoicing orders, payments are processed * fix: correcting to pick up emails, either the default, or those created from the default * feat: changing the display of labels in the admin * feat: adding expiration validation to access payment link success page * fix: only 'vindi_vr_payment_link_template' custom email template * fix: change form with get status * feat: implementing single view system on success page * refactor: line comment * fix: plan form format --------- Co-authored-by: Iago Cedran <[email protected]> Co-authored-by: Thiago Contardi <[email protected]> Co-authored-by: Caroline Esteves <[email protected]> * Novo layout do cartão de crédito na página de checkout (#138) * feat: removed deprecated magento 2 classes * feat: removed deprecated magento 2 classes * fix: remove unused patch * fix: call non existing class * fix: return composer version * Versionamento da 2.1.0 * feat: new card layout * fix: same input id for different fields * fix: cacheable false for product view * fix: add cache key info product block * feat: added all available brands --------- Co-authored-by: Iago Cedran <[email protected]> Co-authored-by: Thiago Contardi <[email protected]> Co-authored-by: Thais Kusuki <[email protected]> Co-authored-by: Thais Kusuki <[email protected]> * inserindo as outras alterações no merge --------- Co-authored-by: Thais Kusuki <[email protected]> Co-authored-by: Iago Cedran <[email protected]> Co-authored-by: Iago Cedran <[email protected]> Co-authored-by: Thiago Contardi <[email protected]> Co-authored-by: Caroline Esteves <[email protected]> Co-authored-by: Contardi <[email protected]> Co-authored-by: Thiago Contardi <[email protected]> Co-authored-by: Thais Kusuki <[email protected]>
cedran
added a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Jan 15, 2025
Novo layout do cartão de crédito na página de checkout (vindi#138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que mudou
a) Foi alterado o novo layout do cartão de crédito para a página de checkout. A alteração é apenas no layout, não sendo alterado a comunicação entre Magento e Vind
b) Foi corrigido um erro de cache FPC na página de produto ocasionado pela tag cacheable="false" no template catalog_product_view.xml,
c) Adicionado tag de cache no bloco de assinatura
Motivação
Foi criado um novo layout de cartão de crédito que seja mais amigável aos usuários.
Solução proposta
Foi aplicado um novo formato, com um script JS para a renderização do formulário de cartão de crédito; durante os testes, foi verificado que a página de produto estava dando bypass no cache FPC, por isso a correção crítica foi aplicada .
Como testar
Para testar, é preciso apenas finalizar a compra com cartão de crédito, o valor na Vindi deve replicar o que foi digitado no Magento, a finalização da compra deve ser efetuada com sucesso.
Loja
https://vindi.loja.biz/