feat: DependsOn files #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenthsh
commented
May 23, 2024
Comment on lines
+156
to
+158
| {{ range $key, $val := .LocalsBlock }} | ||
| {{ $key }} = {{ $val }} | ||
| {{ end }} |
There was a problem hiding this comment.
these will always be sorted!
gotemplate sorts maps by keys
golang/go@a5950df
vincenthsh
commented
May 23, 2024
Comment on lines
118
to
121
| locals { | ||
| bar = jsondecode(file("../../../bar.json")) | ||
| foofoofoo = yamldecode(file("../../../foofoofoo.yaml")) | ||
| } |
There was a problem hiding this comment.
Adding file dependencies makes their content available through locals.
vincenthsh
commented
May 23, 2024
config/v2/validation.go
Outdated
Comment on lines
511
to
535
| func (c *Config) ValidateFileDependencies(fs afero.Fs) error { | ||
| var errs *multierror.Error | ||
| c.WalkComponents(func(component string, comms ...Common) { | ||
| files := ResolveOptionalStringSlice(DependsOnFilesGetter, comms...) | ||
| for _, file := range files { | ||
| if _, err := fs.Stat(file); os.IsNotExist(err) { | ||
| errs = multierror.Append(err, fmt.Errorf("File does not exist: %s\n", file)) | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| return errs.ErrorOrNil() | ||
| } |
There was a problem hiding this comment.
fogg validates file dependencies exist
vincenthsh
force-pushed
the
feat-depends-on-file
branch
from
72e8909 to
70f9dcc
Compare
vincenthsh
commented
May 24, 2024
Comment on lines
+119
to
+120
| bar = jsondecode(file("../../../bar.json")) | ||
| foo_foo_foo = yamldecode(file("../../../foo-fooFoo.yaml")) |
There was a problem hiding this comment.
tf vars are tflint naming convention compliant
vincenthsh
commented
May 24, 2024
config/v2/validation.go
Outdated
Comment on lines
520
to
525
| if convertedNames[convertedName] { | ||
| errs = multierror.Append(errs, fmt.Errorf("files %v, Collision detected for converted filename: %s\n", convertedName, files)) | ||
| } else { |
There was a problem hiding this comment.
config validation detects variable name collisions
vincenthsh
force-pushed
the
feat-depends-on-file
branch
from
70f9dcc to
7043937
Compare
- Add ability to depend on files - Convert file names to terraform naming convention (snake_case). - Validate file name collisions in config implements #304
vincenthsh
force-pushed
the
feat-depends-on-file
branch
from
7043937 to
9fe63c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to depend on files
implements #304