Parse command start #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only looks at the start event, as experiments in a different branch showed that matching the end event is too unreliable.
I played around with more detailed stats, but they didn't seem that useful in the end, so for now I'm just classifying commands as merge/clean/sync. Note that portage doesn't log all commands, so the available data isn't as right as I thought.
This currently somewhat mirrors what qlop offers, as an MVP to get a feel of the implementation. I initially wrote a single-pass version (droping previous table rows when encountering a command), but the two-pass version is fast enough that `--lastmerge` is about as fast as `--last`, and offers more flexibility. Tentative todo: * Allow `--lastmerge <N>` * Move into `--from '1 command'` (simpler and more consistent) * Optionaly ignore non-merge commands (qlop always/only does that, but it's a failible heuristic) * Investigate `--to` support * Move code into get_hist (DRY, and optimization opportunities) * Test and document
* Can now specify command number, and use for both bounds * Works for all commands, not just `log` * More ergonomic I feel, but maybe not as discoverable * No more surprising interaction between `--lastmerge` and `--from` * The effective bounds are still a bit counterintuitive I hoped to save an `open()` syscall, but gzip doesn't `impl Seek`.
* Users expect `--from=1c` to start at the last command * Reject `0c`, accept `c` * Add unittest, tweak inline help
Appended a non-sync emerge command to `benches/emerge.log` so that qlop finds something to display. This is a nice illustration of how unreliable any "detect end of command" heuristics is. It comforts me in the decision to not exactly match qlop's `--lastmerge` behavior (ignoring emerge commands that didn't actually merge something): I value correctness over simplicity.
vincentdephily
force-pushed
the
parse_command_start
branch
from
d3a8425 to
541c0f3
Compare
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that's all the features we can do, given that I couldn't find a reliable enough heuristic to match a command start with a command end.