Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Nested stack #134

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Nested stack #134

wants to merge 13 commits into from

Conversation

olmax99
Copy link

@olmax99 olmax99 commented Nov 4, 2019

1. Comments

  • Comments are good, we love comments!!

2. Structure

  • More granular templates folder <- easier for maintaining and debugging
    • turbine-resource.template contains all the Turbine support services
    • The security groups have a dedicated template
    • CI has its own sub folder
  • Templates split in cluster, services, and ci

3. Log and Deployment Bucket

  • Private Buckets by default (explicit)

Incident: After dag run, CloudFormation DELETE_FAILED with "Logs and Deployment
Bucket are not empty"

  • Added custom Cfn event + Lambda function for cleaning deployments bucket
    content when delete-stack
  • Retain Logs bucket for error investigation or dag data archiving

@villasv
Copy link
Owner

villasv commented Nov 4, 2019

Oohh this is good stuff. Gonna review it soon.

@villasv villasv force-pushed the develop branch 3 times, most recently from bfcf54a to ecdeb57 Compare November 15, 2019 22:20
@villasv villasv force-pushed the develop branch 9 times, most recently from 5451f5a to 9a66de4 Compare January 28, 2020 01:21
@villasv villasv force-pushed the develop branch 3 times, most recently from 1011ae2 to aa1b672 Compare March 22, 2020 02:01
@villasv villasv force-pushed the develop branch 2 times, most recently from 22d88dd to 29df9f4 Compare April 5, 2020 05:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olmax99 @villasv