-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
August 2024 update #269
Merged
Merged
August 2024 update #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran Autopep8 on all files in repo, they are otherwise untouched with one exception: In the __init__ file, I had to manually rearrange the import statements to avoid triggering a circular import error. This will be addressed in a future commit. Updated authors in bl_info to: 'Vilem Novak & Contributors' - this can be changed as required Updated version to: 1.0.5
Ran Autopep8 on all files in repo, they are otherwise untouched with one exception: In the __init__ file, I had to manually rearrange the import statements to avoid triggering a circular import error. This will be addressed in a future commit. Updated authors in bl_info to: 'Vilem Novak & Contributors' - this can be changed as required Updated version to: 1.0.5
Ran Autopep8 on all files in repo, they are otherwise untouched with one exception: In the __init__ file, I had to manually rearrange the import statements to avoid triggering a circular import error. This will be addressed in a future commit. Updated authors in bl_info to: 'Vilem Novak & Contributors' - this can be changed as required Updated version to: 1.0.5
Changed the formatting of Properties (e.g. bpy.props.StringProperty) throughout: Before: ``` use_position_definitions: bpy.props.BoolProperty(name="Use position definitions", description="Define own positions for op start, " "toolchange, ending position", default=False) ``` After: ``` use_position_definitions: BoolProperty( name="Use position definitions", description="Define own positions for op start, " "toolchange, ending position", default=False, ) ``` Added trailing commas to retain formatting if another autoformatter (e.g.: black) is implemented. Removed bpy.props. prefix from Properties that still had it, and added explicit imports when required in ui_panels module.
Changed the formatting of Properties (e.g. bpy.props.StringProperty) throughout: Before: ``` use_position_definitions: bpy.props.BoolProperty(name="Use position definitions", description="Define own positions for op start, " "toolchange, ending position", default=False) ``` After: ``` use_position_definitions: BoolProperty( name="Use position definitions", description="Define own positions for op start, " "toolchange, ending position", default=False, ) ``` Added trailing commas to retain formatting if another autoformatter (e.g.: black) is implemented. Removed bpy.props. prefix from Properties that still had it, and added explicit imports when required in ui_panels module.
Changed the formatting of Properties (e.g. bpy.props.StringProperty) throughout: Before: ``` use_position_definitions: bpy.props.BoolProperty(name="Use position definitions", description="Define own positions for op start, " "toolchange, ending position", default=False) ``` After: ``` use_position_definitions: BoolProperty( name="Use position definitions", description="Define own positions for op start, " "toolchange, ending position", default=False, ) ``` Added trailing commas to retain formatting if another autoformatter (e.g.: black) is implemented. Removed bpy.props. prefix from Properties that still had it, and added explicit imports when required in ui_panels module.
Property format
Changed all imports from absolute to relative: - instead of importing the module 'cam' now imports come from '.' the relative parent folder - importing the module into itself resulted in a circular import error, relative imports avoid this Moved Functions, refs updated: - some functions (and 2 variables) only existed on the base level of the module, in the init file, and could not otherwise be accessed, they were moved into the utils file with other similar functions - these were primarily called as update functions for Properties scattered across the addon, these have all been updated to reflect the new location and import convention opencamlib_version rename: - in 2 files there was a local variable named 'opencamlib_version' that was defined by a function called 'opencamlib_version' that returned the opencamlib_version - this seemed to confuse Blender into thinking that it was being called before it was defined, and simply changing the variable name to 'ocl_version' while keeping the function name as 'opencamlib_version' fixed the issue
Changed all imports from absolute to relative: - instead of importing the module 'cam' now imports come from '.' the relative parent folder - importing the module into itself resulted in a circular import error, relative imports avoid this Moved Functions, refs updated: - some functions (and 2 variables) only existed on the base level of the module, in the init file, and could not otherwise be accessed, they were moved into the utils file with other similar functions - these were primarily called as update functions for Properties scattered across the addon, these have all been updated to reflect the new location and import convention opencamlib_version rename: - in 2 files there was a local variable named 'opencamlib_version' that was defined by a function called 'opencamlib_version' that returned the opencamlib_version - this seemed to confuse Blender into thinking that it was being called before it was defined, and simply changing the variable name to 'ocl_version' while keeping the function name as 'opencamlib_version' fixed the issue
Changed all imports from absolute to relative: - instead of importing the module 'cam' now imports come from '.' the relative parent folder - importing the module into itself resulted in a circular import error, relative imports avoid this Moved Functions, refs updated: - some functions (and 2 variables) only existed on the base level of the module, in the init file, and could not otherwise be accessed, they were moved into the utils file with other similar functions - these were primarily called as update functions for Properties scattered across the addon, these have all been updated to reflect the new location and import convention opencamlib_version rename: - in 2 files there was a local variable named 'opencamlib_version' that was defined by a function called 'opencamlib_version' that returned the opencamlib_version - this seemed to confuse Blender into thinking that it was being called before it was defined, and simply changing the variable name to 'ocl_version' while keeping the function name as 'opencamlib_version' fixed the issue
version was previously only updated in bl_info, it has now been updated to match in the version.py file as well, which should allow it to display in the main UI.
While rearranging and cleaning up the utils imports in the initial 'Import fix' commit I deleted `utils.` from `bpy.utils.script_paths()` in the ops.py file. This has been fixed, and I took the opportunity to reverse the autoformat issue (changed line length from 100 to 89 between commits), and restore all the code to its previous state. I made one exception: - comments that came at the end of the line that were moved to the line above All functional code has been restored to its previous format.
While rearranging and cleaning up the utils imports in the initial 'Import fix' commit I deleted `utils.` from `bpy.utils.script_paths()` in the ops.py file. This has been fixed, and I took the opportunity to reverse the autoformat issue (changed line length from 100 to 89 between commits), and restore all the code to its previous state. I made one exception: - comments that came at the end of the line that were moved to the line above All functional code has been restored to its previous format.
While rearranging and cleaning up the utils imports in the initial 'Import fix' commit I deleted `utils.` from `bpy.utils.script_paths()` in the ops.py file. This has been fixed, and I took the opportunity to reverse the autoformat issue (changed line length from 100 to 89 between commits), and restore all the code to its previous state. I made one exception: - comments that came at the end of the line that were moved to the line above All functional code has been restored to its previous format.
While rearranging and cleaning up the utils imports in the initial 'Import fix' commit I deleted `utils.` from `bpy.utils.script_paths()` in the ops.py file. This has been fixed, and I took the opportunity to reverse the autoformat issue (changed line length from 100 to 89 between commits), and restore all the code to its previous state. I made one exception: - comments that came at the end of the line that were moved to the line above All functional code has been restored to its previous format.
Caught a handful more lines that needed to be reverted to clean up the diff.
Caught a handful more lines that needed to be reverted to clean up the diff.
Caught a handful more lines that needed to be reverted to clean up the diff.
Caught a handful more lines that needed to be reverted to clean up the diff.
There was a space in bl_info and that caused some bugs.
Fix for 1.0.8 Install Error
License update, format header comment
fix overcut
reduce the remove_ double_ distance
Added a few lines to the end of the register function in the __init__ file to ensure that the required curve addons are activated when the addon is installed. Also removed the docstring from version.py as I believe it interfered with the regex in the Github Action
Blender restricts access to context (required to read and update the addons in preferences) during registration, so the initial implementation would not work. This update moves the logic into the utils file in the `check_operations_on_load` function.
Curve Addons & Version Update
…l work on blender 4.1.1
…l work on blender 4.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of tweeks here and there.
Removed safety wheels for cut_bridges
changed engine name to CNC CAM instead of BlenderCAM To respect trademark.
Overcut fixed
licence update
pie menu
operation preset update
import fix
medial fix
shapely 2 API speed improvement
MAC bug fix
Blender 4 fixes