Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export config at /config instead of / #56

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Jan 28, 2024

@magne4000 feel free to push back on some changes

Partly aligns with vike-react and vike-vue (similar to vikejs/vike-vue#75)

BREAKING CHANGE: Update Vike to 0.4.160 or above.

BREAKING CHANGE: Replace import vikeSolid from 'vike-solid' with import vikeSolid from 'vike-solid/config'. (Typically in your /pages/+config.h.js.)

Partly aligns with vike-react and vike-vue

BREAKING CHANGE: Update Vike to `0.4.160` or above.

BREAKING CHANGE: Replace `import vikeSolid from 'vike-solid'`
with `import vikeSolid from 'vike-solid/config'`. (Typically
in your `/pages/+config.h.js`.)
@magne4000
Copy link
Member

Having as little differences between each vike-* repo as possible seems like a good idea, beside that I do not have a strong opinion on the matter 👍

@magne4000 magne4000 merged commit bc5504a into main Jan 29, 2024
12 checks passed
@magne4000 magne4000 deleted the aurelien/bugfix/import-config branch January 29, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants