feat: new extension vike-solid-query
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the `vike-solid` project from the root directory to `packages/vike-solid`. - Updated scripts and dependencies to align with `vike-react` and ensure proper functionality. - Verified build and test processes to confirm successful migration. - Updated `README.md` in the root directory and `packages/vike-solid` directory to reflect the new project location.
…zammi/feat-vike-solid-query2
…zammi/feat-vike-solid-query2
phonzammi
force-pushed
the
phonzammi/feat-vike-solid-query2
branch
from
3ff0694
to
3091389
Compare
magne4000
reviewed
Sep 4, 2024
…zammi/feat-vike-solid-query2
|
@magne4000, LGTM ? @brillout, we’d love to hear your thoughts on this. |
Let's just merge and continue the work on another PR 👍 |
magne4000
approved these changes
Sep 4, 2024
|
I quickly glazed over the readme; looks good. I wonder if it's possible to have the interface be more like FYI there are couple of typos, inconsistent code formatting, and markdown formatting errors in the readme. Nothing much changed on LGTM. |
|
Also, the main readme needs to be updated. I've aded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@magne4000 @brillout
Please take a look and review this PR.
Note that I haven’t added any tests for
vike-solid-queryyet because we need to add some code tovike-solidto detectcrawlers and bots, and then use renderToStringAsync() for that. Also a bit of refactor.As Rom suggested, maybe we could merge this since we've refactored to a monorepo and continue with the remaining work in a separate PR.
closes #94