Fix display in dark theme

[hongquan]

Description

The orignal DALF has bad display in dark mode:

Here is after the fix:

Related Issue(s)

This pull request is related to issue(s) #.

Type of change

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

Just replace original DALF with this fork.

Checklist

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• Any dependent changes have been merged and published in downstream modules.

[vigo]

hi @hongquan, thanx for the pr. tests are failing. can you please check?

[vigo]

>                   assert (
                        f'<select class="django-admin-list-filter" name="{option_field_name}" '
                        f'data-is-choices-filter="{option_is_choices_filter}">'
                    ) in content

should be:

>                   assert (
                        f'<select class="django-admin-list-filter admin-autocomplete" name="{option_field_name}" '
                        f'data-is-choices-filter="{option_is_choices_filter}">'
                    ) in content

[hongquan]

@vigo I have pushed the fix for test case, but somehow GH Action does not run.

[vigo]

I see this, looks fine to me? if it's ok, i'll merge and release?

[hongquan]

@vigo That display is not as expected.

Ah, the "by author" is as expected. The "by category" is not.

[vigo]

@hongquan I'm a bit confused :)

by author is DALFRelatedOnlyFieldand operating system is in light mode, django is in dark mode:

by category is DALFRelatedFieldAjax and operating system is in light mode, django is in dark mode

i guess i should see by category (selection is open) as i've seen it in by author right? (this is your PR that i'm running)

[vigo]

@hongquan found it, please add this part in django_admin_list_filter_ajax.html, add: data-theme="admin-autocomplete":

{% load i18n %}
<details data-filter-title="{{ title }}" open>
    <summary>
        {% blocktranslate with filter_title=title %} By {{ filter_title }} {% endblocktranslate %}
    </summary>
    <form method="get">
        <ul>
            <li>
                {% with params=choices|last %}
                    <input class="djal-selected-value" type="hidden" value="{{ params.selected_value|default_if_none:'' }}" />
                    <select
                      class="django-admin-list-filter-ajax"
                      data-ajax--cache="true"
                      data-ajax--delay="250"
                      data-ajax--type="GET"
                      data-ajax--url="{{ params.ajax_url }}"
                      data-placeholder="{{ _('All') }}"
                      data-allow-clear="true"
                      data-app-label="{{ params.app_label }}"
                      data-model-name="{{ params.model_name }}"
                      data-theme="admin-autocomplete"  <------- this line only
                      data-field-name="{{ params.field_name }}"></select>
                {% endwith %}
              </li>
          </ul>
      </form>
</details>

[vigo]

@hongquan thank you