Merge pull request #136 from root-intruder/master

fix FakeADBServer testcases which expect certain commands
vidstige · Mar 5, 2021 · cfc66ff · cfc66ff
2 parents d756538 + 3ace8c8
commit cfc66ff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/se/vidstige/jadb/test/unit/MockedTestCases.java b/test/se/vidstige/jadb/test/unit/MockedTestCases.java
@@ -99,7 +99,7 @@ public void testPullFile() throws Exception {
     @Test
     public void testExecuteShell() throws Exception {
         server.add("serial-123");
-        server.expectShell("serial-123", "ls -l").returns("total 0");
+        server.expectShell("serial-123", "ls '-l'").returns("total 0");
         JadbDevice device = connection.getDevices().get(0);
         device.executeShell("ls", "-l");
     }

diff --git a/test/se/vidstige/jadb/test/unit/PackageManagerTest.java b/test/se/vidstige/jadb/test/unit/PackageManagerTest.java
@@ -44,7 +44,7 @@ public void testGetPackagesWithSeveralPackages() throws Exception {
         String response = "package:/system/priv-app/Contacts.apk-com.android.contacts\n" +
                 "package:/system/priv-app/Teleservice.apk-com.android.phone";
 
-        server.expectShell(DEVICE_SERIAL, "pm list packages").returns(response);
+        server.expectShell(DEVICE_SERIAL, "pm 'list' 'packages'").returns(response);
 
         //Act
         List<Package> actual = new PackageManager(device).getPackages();
@@ -64,7 +64,7 @@ public void testGetPackagesMalformedIgnoredString() throws Exception {
                 "[malformed_line]\n" +
                 "package:/system/priv-app/Teleservice.apk-com.android.phone";
 
-        server.expectShell(DEVICE_SERIAL, "pm list packages").returns(response);
+        server.expectShell(DEVICE_SERIAL, "pm 'list' 'packages'").returns(response);
 
         //Act
         List<Package> actual = new PackageManager(device).getPackages();
@@ -79,7 +79,7 @@ public void testGetPackagesWithNoPackages() throws Exception {
         List<Package> expected = new ArrayList<>();
         String response = "";
 
-        server.expectShell(DEVICE_SERIAL, "pm list packages").returns(response);
+        server.expectShell(DEVICE_SERIAL, "pm 'list' 'packages'").returns(response);
 
         //Act
         List<Package> actual = new PackageManager(device).getPackages();