Skip to content

Commit

Permalink
Playwright CI (google#4268)
Browse files Browse the repository at this point in the history
* tests run

* fixed most tests

* fixed more tests

* update CI

* update effects testing

* increase timeouts

* disable firefox

* simpler logs

* longer timeouts

* skip flaky tests

* more flakes

* more flakes

* raf

* ease up test

* remove karma from model-viewer

* space-opera jasmine->mocha

* fixed tests

* cleanup

* update lock

* extend timeout

* up space-opera timeouts

* webkit fail

* debug CI

* try disabling renderer suite

* cleanup

* add devices to CI

* fixed more tests

* deflake

* remove old work-arounds

* narrow webkit failure

* cleanup

* revert accidental replace
  • Loading branch information
elalish authored May 9, 2023
1 parent 3345a0a commit 7fdf88c
Show file tree
Hide file tree
Showing 97 changed files with 8,248 additions and 16,539 deletions.
2 changes: 0 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ packages/*/dist
packages/**/*.d.ts
packages/*/src/*-css.ts

packages/*/karma.*.js

packages/model-viewer/**/*
packages/model-viewer-effects/**/*
packages/modelviewer.dev/**/*
Expand Down
31 changes: 0 additions & 31 deletions .github/workflows/unit-tests-third-party.yml

This file was deleted.

26 changes: 4 additions & 22 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,10 @@ on: [push]
jobs:
full_test_run:

env:
USE_BROWSER_STACK: true

runs-on: ubuntu-latest
timeout-minutes: 60

steps:
- name: 'BrowserStack Env Setup' # Invokes the setup-env action
uses: browserstack/github-actions/setup-env@master
with:
username: ${{ secrets.BROWSER_STACK_USERNAME }}
access-key: ${{ secrets.BROWSER_STACK_ACCESS_KEY }}

- name: 'BrowserStack Local Tunnel Setup' # Invokes the setup-local action
uses: browserstack/github-actions/setup-local@master
with:
local-testing: start
local-identifier: test
local-logging-level: setup-logs

- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
Expand All @@ -33,6 +17,9 @@ jobs:
- name: NPM install
run: npm ci

- name: Install playwright browsers
run: npx playwright install --with-deps

# - name: Lint TypeScript sources
# run: npm run lint

Expand All @@ -43,9 +30,4 @@ jobs:
run: npm run build

- name: Unit tests
run: npm run test:ci

- name: 'BrowserStackLocal Stop' # Terminating the BrowserStackLocal tunnel connection
uses: browserstack/github-actions/setup-local@master
with:
local-testing: stop
run: npm run test:ci
120 changes: 60 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7fdf88c

Please sign in to comment.