feat: add support for #EXT-X-DEFINE #185
Conversation
| The constructor optinally takes an options object with two properties. These are needed when using `#EXT-X-DEFINE` for variable replacement. | ||
|
|
||
| ```js | ||
| var parser = new m3u8Parser.Parser({ |
There was a problem hiding this comment.
this seems reasonable to me. The only thing to consider is whether the options property for definitions should match the value provided by the parser.
So that you could pass the output of the parser from the main playlist directly in to the parser for the media playlist.
There was a problem hiding this comment.
The ideas was that mainDefinitions: main.defintions would be added to the object here, and parseManifest_ would pass that on.
As is, no, it would be the responsibility of http-streaming or another consumer to listen to that error event and to reject the playlist. Throwing an error and not returning any manifest would be more spec compliant, if we want to do that. |
src/parser.js
Outdated
| // QUERYPARAM attribute, but only one of the three. Otherwise, the | ||
| // client MUST fail to parse the Playlist. | ||
| this.trigger('error', { | ||
| message: 'EXT-X-DEFINE: Invalid attriibutes' |
There was a problem hiding this comment.
| message: 'EXT-X-DEFINE: Invalid attriibutes' | |
| message: 'EXT-X-DEFINE: Invalid attributes' |
Co-authored-by: Dzianis Dashkevich <[email protected]>
Adds support for #EXT-X-DEFINE.
This requires the parser to have additional information it currently doesn't know: the playlist's URI, and for a media playlist, any variables that have been defined in the main/multivariant playlist. The proposal is to pass an object with the url and defined variables as a constructor argument.
This would need changes to http-streaming to make use of it, to pass those options in.