Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update m3u8-parser version and fix tests #1407

Merged
merged 3 commits into from
Jul 11, 2023
Merged

chore: update m3u8-parser version and fix tests #1407

merged 3 commits into from
Jul 11, 2023

Conversation

harisha-swaminathan
Copy link
Contributor

@harisha-swaminathan harisha-swaminathan commented Jul 10, 2023 •
edited
Loading

Updates m3u8-parser version to 7.0, replaces dateTimeObject and dateTimeString with programDateTime and fixes tests

@harisha-swaminathan harisha-swaminathan marked this pull request as ready for review July 11, 2023 02:13
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #1407 (5bbe96b) into main (a21182d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1407   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files          40       40           
  Lines       10028    10028           
  Branches     2322     2322           
=======================================
  Hits         8572     8572           
  Misses       1456     1456
Impacted Files Coverage Δ
src/segment-loader.js 96.47% <ø> (ø)
src/sync-controller.js 97.44% <100.00%> (ø)
src/util/time.js 92.68% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harisha-swaminathan harisha-swaminathan changed the title update m3u8-parser version and fix tests chrore: update m3u8-parser version and fix tests Jul 11, 2023
adrums86
adrums86 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small typo in the title chrore: instead of chore:. 😄

@harisha-swaminathan harisha-swaminathan changed the title chrore: update m3u8-parser version and fix tests chore: update m3u8-parser version and fix tests Jul 11, 2023
@harisha-swaminathan harisha-swaminathan merged commit fe25a04 into main Jul 11, 2023
14 checks passed
@harisha-swaminathan harisha-swaminathan deleted the update-m3u8-parser branch July 11, 2023 22:47
@harisha-swaminathan harisha-swaminathan mentioned this pull request Aug 4, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrums86 adrums86 adrums86 approved these changes

@dzianis-dashkevich dzianis-dashkevich dzianis-dashkevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harisha-swaminathan @adrums86 @dzianis-dashkevich